Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Implement v8 Inspector Protocol#329

Merged
gaofanmichael merged 17 commits intogoogleapis:masterfrom
gaofanmichael:feature/interface2
Sep 25, 2017
Merged

Implement v8 Inspector Protocol#329
gaofanmichael merged 17 commits intogoogleapis:masterfrom
gaofanmichael:feature/interface2

Conversation

@gaofanmichael
Copy link
Copy Markdown
Contributor

@gaofanmichael gaofanmichael commented Sep 11, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2017
kjin
kjin reviewed Sep 13, 2017
View reviewed changes
src/agent/debugapi.ts Outdated
if (singleton && !config_.forceNewAgent_) {
return singleton;
}
let debugapi: any;

This comment was marked as spam.

Sign in to view

kjin
kjin suggested changes Sep 21, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments - feel free to ping me on anything I need to elaborate on.

src/agent/debugapi.ts Outdated
sourcemapper_: SourceMapper): DebugApi;
}
let debugApiConstructor: DebugApiConstructor;
let nodeVersion = /v(\d+\.\d+\.\d+)/.exec(process.version);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/debugapi.ts Outdated
let nodeVersion = /v(\d+\.\d+\.\d+)/.exec(process.version);
if (!nodeVersion || nodeVersion.length < 2) {
console.error('can\'t get the node version.');
process.exit(1);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/debugapi.ts Outdated
let debugapi: any;
debugapi = new debugApiConstructor(logger_, config_, jsFiles_, sourcemapper_);

singleton = {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/debugapi.ts Outdated
singleton.disconnect();
}

let debugapi: any;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/debugapi.ts Outdated
let singleton: DebugApi;

export function create(
logger_: Logger, config_: DebugAgentConfig, jsFiles_: ScanStats,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/state-inspector.ts
*
* @return an object with error and mirror fields.
*/
export function evaluate(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/state-inspector.ts Outdated
// Evaluate the watch expressions
const evalIndexSet = new Set();
if (this.expressions_) {
this.expressions_.forEach(async (expression, index2) => {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/state-inspector.ts Outdated
}

resolveFullPath_(frame: inspector.Debugger.CallFrame): string {
let scriptId: string = frame.location.scriptId;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/state-inspector.ts Outdated
varTableIndex: ARG_LOCAL_LIMIT_MESSAGE_INDEX
});
} else {
args = [];

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/state-inspector.ts Outdated
* name.
* @function resolveLocalsList_
* @memberof StateResolver
* @param {FrameMirror} frame - A instance of FrameMirror

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@kjin
Copy link
Copy Markdown
Contributor

kjin commented Sep 21, 2017

Also, could you give this PR (and future PRs) a more descriptive title than its branch name?

@gaofanmichael gaofanmichael changed the title Feature/interface2 Implement v8 Inspector Protocol Sep 25, 2017
kjin
kjin suggested changes Sep 25, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. I left a few more comments... should be good to go once you've addressed these.

src/agent/inspectordebugapi.ts
public id: string, public active: boolean,
public apiBreakpoint: apiTypes.Breakpoint,
public parsedCondition: estree.Node,
public compile: null|((src: string) => string)) {}

This comment was marked as spam.

Sign in to view

src/agent/debugapi.ts Outdated
const nodeVersion = /v(\d+\.\d+\.\d+)/.exec(process.version);

if (!nodeVersion || nodeVersion.length < 2) {
console.error(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/inspectordebugapi.ts Outdated
try {
this.handleDebugPausedEvent(message.params);
} catch (error) {
console.error(error);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/inspectordebugapi.ts Outdated
}
}

handleDebugPausedEvent(params: inspector.Debugger.PausedEventDataType) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/debugapi.ts Outdated

export function create(
logger: Logger, config: DebugAgentConfig, jsFiles: ScanStats,
sourcemapper: SourceMapper): DebugApi|null {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/inspectordebugapi.ts Outdated
utils.messages.V8_BREAKPOINT_CLEAR_ERROR);
}
const id = breakpoint.id;
let result = this.v8Inspector.removeBreakpoint(breakpointData.id);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/inspectordebugapi.ts Outdated
breakpoint.logMessageFormat as string,
// TODO: Determine how to remove the `as` cast below
breakpoint.evaluatedExpressions.map(
JSON.stringify as (ob: any) => string));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/state-inspector.ts Outdated
scriptmapper: {[id: string]: any}, v8Inspector: V8Inspector) {
this.callFrames_ = callFrames;
this.breakpoint_ = breakpoint;
this.expressions_ = breakpoint.expressions as string[];

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/state-inspector.ts Outdated
assert(!this.resolvedVariableTable_[index]); // shouldn't have it
// resolved yet
const isEvaluated = evalIndexSet.has(index);
if (this.rawVariableTable_[index].objectId)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/agent/state-inspector.ts
for (let i = 0; i < count; ++i) {
let result = this.v8Inspector_.getProperties(
frame.scopeChain[i].object.objectId as string);
if (result.response && !isEmpty(result.response.result)) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

kjin
kjin approved these changes Sep 25, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaofanmichael gaofanmichael merged commit 3114892 into googleapis:master Sep 25, 2017
@gaofanmichael gaofanmichael deleted the feature/interface2 branch September 29, 2017 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewloring matthewloring Awaiting requested review from matthewloring

@ofrobots ofrobots Awaiting requested review from ofrobots

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

1 more reviewer

@kjin kjin kjin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaofanmichael @kjin @jmdobry @googlebot