Address TODOs by DominicKramer · Pull Request #324 · googleapis/cloud-debug-nodejs

DominicKramer · 2017-08-08T18:26:16Z

As part of the change to Typescript, many TODOs were added to the code for items to address. This PR addresses some of these TODOs.

The `extractArgumentsList_` method is not used.

src/agent/debuglet.ts

            // TODO: Address the case when `id` is `undefined`.
            project, id as string, that.config_.serviceContext, sourceContext,
-            that.config_.description, null, onGCP);
+            onGCP, that.config_.description, undefined);


test/test-debuglet.ts

          // TODO: Verify that `null` for minorVersion_ should be used here
          //       or if minorVersion_ should be optional.
-          {service: 'some-service', version: 'production', minorVersion_: null},
+          {service: 'some-service', version: 'production', minorVersion_: undefined},


test/test-debuglet.ts

          // TODO: Determine if these are the correct values that should be
          //       use here.
-          {}, null, null, false);
+          {}, false, undefined, undefined);


test/test-debuglet.ts

                                  // TODO: Verify that `null` for minorVersion_ should be used here
                                  //       or if minorVersion_ should be optional.
-                                  {service: 'default', version: 'yellow.5', minorVersion_: null},
+                                  {service: 'default', version: 'yellow.5', minorVersion_: undefined},


test/test-debuglet.ts

                                  // TODO: Determine if these are the correct values that should be
                                  //       use here.
-                                  {}, null, null, false);
+                                  {}, false, undefined, undefined);


test/test-debuglet.ts

-             'a', 'b', undefined as any, undefined as any, undefined as any, 'Some Error Message',
             // TODO: Determine if this value for onGCP is correct.
-             false);
+             'a', 'b', undefined as any, undefined as any, false, undefined as any, 'Some Error Message');


src/agent/state.ts

 import {DebugAgentConfig} from './config';

-// TODO: Determine if `ScopeType` should be named `scopeType`.
-// tslint:disable-next-line:variable-name


This reverts commit 979fa02.

src/agent/config.ts

+  description?: string;

  /**
   * Whether or not it is permitted to evaluate expressions.


src/agent/debuglet.ts

+  private debugletApi_: Controller;
+  private completedBreakpointMap_: {[key: string]: boolean};
+
+  // Exposed for testing


DominicKramer added 10 commits August 8, 2017 11:21

Change T|null to optional types in config.ts

bbba199

Make DebuggeeProperties.statusMessage optional

e69a3e2

Address some TODOs in debuggee.ts

300dac6

Address TODOs in validator.ts

27d20fd

Address some TODOs in v8debugapi.ts

5fd40a2

Format v8debugapi.ts

965ed19

Rename ScopeType to scopeType

979fa02

Remove the extractArgumentsList_ method

4d68e3f

The `extractArgumentsList_` method is not used.

Address some TODOs in debuglet.ts

8c37498

Address some TODOs in the system tests

1e350e5

jmdobry added the in progress label Aug 8, 2017

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2017

ofrobots reviewed Aug 8, 2017

View reviewed changes

DominicKramer added 2 commits August 8, 2017 16:43

Address GitHub comments

4230e12

Revert "Rename ScopeType to scopeType"

99761a9

This reverts commit 979fa02.

ofrobots approved these changes Aug 9, 2017

View reviewed changes

matthewloring reviewed Aug 9, 2017

View reviewed changes

DominicKramer merged commit b58b2f7 into googleapis:master Aug 9, 2017

jmdobry removed the in progress label Aug 9, 2017

DominicKramer deleted the cleanup/address-todos branch October 9, 2017 20:58

Conversation

DominicKramer commented Aug 8, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants