Update the tests to use import syntax#316
Conversation
googlebot
added
the
cla: yes
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
This change is going to introduce a really large number of TODOs. Would it be possible to address some of the lower hanging fruit as part of this change? For example the extra parameter on isError seems to just be incorrect and should be removed.
| const qs: { parse: (qs: any, sep?: string, eq?: string, | ||
| options?: { maxKeys?: number }) => any, | ||
| stringify: (obj: object|string|boolean|number, sep?: string, | ||
| eq?: string, name?: string) => string} = require('querystring'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@matthewloring I tried to have each PR only change things that were actually needed to be changed for transpilation and tests to pass. I think this will make it easier to review these changes as well as, in the future, review git history of the changes. As a result, a lot of TODOs were introduced, but I think follow-up PRs to address them should be ok. |
4 participants
No description provided.