This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Merged
Conversation
googlebot
added
the
cla: yes
DominicKramer
approved these changes
Jul 7, 2017
Contributor
DominicKramer
left a comment
DominicKramer
left a comment
There was a problem hiding this comment.
LGTM. I agree package-lock.json is the way to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking both in the repo is problematic, as they can get out of date and different users will get different results depending on whether they are using yarn or npm. I expect that over time yarn will switch to using package-lock.json as well, and given that more folks are using npm, it makes more sense to switch to package-lock.json.