This repository was archived by the owner on Apr 3, 2024. It is now read-only.
lint, tooling, and other misc. changes#304
Merged
ofrobots merged 2 commits intogoogleapis:masterfrom Jul 7, 2017
Merged
Conversation
* Remove jshint files and devDependency * Update tslint config. Use typechecked lint. Remove options that are subsumed by the compiler now. * Start shipping type definitions. * Address newly found lint errors. * Formatting.
googlebot
added
the
cla: yes
DominicKramer
approved these changes
Jul 7, 2017
Contributor
DominicKramer
left a comment
DominicKramer
left a comment
There was a problem hiding this comment.
LGTM. Also, jshint was also used in ./bin/run-test.sh, but is now commented out. I think that line can now be removed entirely.
Contributor
Author
|
Thanks, removed the commented out jshint invocation from run-test.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by the compiler now.