Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Lint and yarn#301

Merged
ofrobots merged 2 commits intogoogleapis:masterfrom
ofrobots:lint-and-yarn
Jul 6, 2017
Merged

Lint and yarn#301
ofrobots merged 2 commits intogoogleapis:masterfrom
ofrobots:lint-and-yarn

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots commented Jul 6, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2017
Copy link
Copy Markdown
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/comments.

const evalIndexSet = new Set();
if (that.expressions_) {
that.expressions_.forEach(function(expression, index) {
that.expressions_.forEach(function(expression, index2) {

This comment was marked as spam.

});

find.on('directory', function(dir: string, _: fs.Stats, stop: () => void) {
find.on('directory', function(dir: string, _ignore: fs.Stats, stop: () => void) {

This comment was marked as spam.

metadata.project(
'project-id',
function(err: Error, _: http.ServerResponse, metadataProject: string) {
function(err: Error, _res: http.ServerResponse, metadataProject: string) {

This comment was marked as spam.

This comment was marked as spam.

@ofrobots ofrobots merged commit 2297c09 into googleapis:master Jul 6, 2017
@ofrobots ofrobots deleted the lint-and-yarn branch July 6, 2017 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants