This repository was archived by the owner on Apr 3, 2024. It is now read-only.
tune up configuration types#300
Merged
ofrobots merged 4 commits intogoogleapis:masterfrom Jul 7, 2017
Merged
Conversation
Contributor
ofrobots
commented
Jul 6, 2017
ofrobots
commented
- Get rid of jsdoc types from comments – not needed now that we TS types. Not entirely sure yet how jsdoc documentation generator handles ts, but we shall find out.
- Proper inheritance for Auth options.
- Fix some TODOs
googlebot
added
the
cla: yes
Contributor
DominicKramer
left a comment
DominicKramer
left a comment
There was a problem hiding this comment.
What about the other types of annotations in JSDoc comments such as specifying a constructor, marking something as const, etc. I don't think those are needed now either.
src/debug.ts
Outdated
| @@ -43,7 +43,7 @@ export class Debug extends common.Service { | |||
| * | |||
| * @param {object} options - [Configuration object](#/docs) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/index.ts
Outdated
| @@ -27,7 +26,6 @@ let debuglet: Debuglet; | |||
| * with Stackdriver Debug. | |||
| * | |||
| * @param {object=} options - Options | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
DominicKramer
approved these changes
Jul 6, 2017
src/index.ts
Outdated
| throw new Error('Debug Agent has already been started'); | ||
| } | ||
|
|
||
| // TODO: Determine how to remove this cast to `AuthOptions`. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.