Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Build and packaging cleanups#296

Merged
ofrobots merged 4 commits intogoogleapis:masterfrom
ofrobots:cleanup
Jun 30, 2017
Merged

Build and packaging cleanups#296
ofrobots merged 4 commits intogoogleapis:masterfrom
ofrobots:cleanup

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots commented Jun 30, 2017

  • Add a files section to the package.json to restrict the files that get shipped as part of the package.
  • No more .js files in the src.ts directory
  • Produce output files in build/src and build/types.
  • Use correct sourceRoot for sourcemaps
  • Run mocha with source map support.

It would be easiest to review commits chronologically.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2017
@ofrobots ofrobots requested a review from DominicKramer June 30, 2017 22:40
Copy link
Copy Markdown
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/comment.

const outDir = '.';
const sources = ['src.ts/**/*.ts', 'src.ts/**/*.js'];
const outDir = 'build';
const sources = ['src.ts/**/*.ts'];

This comment was marked as spam.

This comment was marked as spam.

@ofrobots ofrobots merged commit 31b6e9f into googleapis:master Jun 30, 2017
@ofrobots ofrobots deleted the cleanup branch June 30, 2017 23:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants