This repository was archived by the owner on Apr 3, 2024. It is now read-only.
typo: wait_expired -> waitExpired#287
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Jun 30, 2017
Merged
Conversation
googlebot
added
the
cla: yes
matthewloring
approved these changes
Jun 28, 2017
Contributor
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
Changes look good. Does it make sense to add a system test for this?
DominicKramer
approved these changes
Jun 28, 2017
Contributor
Author
|
We already had a system test: https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/blob/master/system-test/test-controller.js#L98 which didn't have the typo :(. I think a more comprehensive system test that actually sets a breakpoint would be needed. |
Contributor
Author
|
Adjusted the e2e test to better exercise waitExpired. Also fix |
| child.transcript); | ||
| }); | ||
| return api.deleteBreakpoint(debuggeeId, breakpoint.id); | ||
| return Promise.resolve(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing breakpoints to be locally expired incorrectly.