Initial gulpfile that only maps src.ts to src by DominicKramer · Pull Request #281 · googleapis/cloud-debug-nodejs

DominicKramer · 2017-06-23T16:31:20Z

No description provided.

kjin

LGTM w/ nit.

gulpfile.js

+});
+
+gulp.task('test', ['test.unit']);
+gulp.task('default', ['compile']);


package.json

-    "coverage": "./bin/run-test.sh -c",
-    "bump": "./bin/run-bump.sh",
-    "closure": "./node_modules/.bin/closure-npc"
+    "test": "gulp test",


.travis.yml

 - '8'
 script:
- ./bin/run-test.sh -c
+- gulp && ./bin/run-test.sh -c


appveyor.yml

 test_script:
  # run tests
-  - ps: node_modules/.bin/mocha test --timeout 4000 --R
+  - ps: node_modules/.bin/gulp ; node_modules/.bin/mocha test --timeout 4000 --R


package.json

@@ -45,11 +54,11 @@
    "split": "^1.0.0"
  },
  "scripts": {


This is used instead of invoking `gulp` directly.

tsconfig.json

+    "allowUnreachableCode": false,
+    "allowUnusedLabels": false,
+    "alwaysStrict": true,
+//    "declaration": true,


ofrobots

This is good to land.

Initial gulpfile that only maps src.ts to src

d2f649e

DominicKramer requested a review from ofrobots June 23, 2017 16:31

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2017

jmdobry added the in progress label Jun 23, 2017

DominicKramer added 2 commits June 23, 2017 09:43

Update .travis.yaml to invoke gulp

62ac165

Update Appveyor to call gulp before running tests

ca1d6c5

kjin approved these changes Jun 23, 2017

View reviewed changes

gulpfile.js

});

gulp.task('test', ['test.unit']);

gulp.task('default', ['compile']); No newline at end of file

This comment was marked as spam.

Sign in to view

DominicKramer added 2 commits June 23, 2017 12:22

Testing the use of ; in appveyor

562320d

Using the absolute path to gulp

2d5e62b

ofrobots reviewed Jun 23, 2017

View reviewed changes

package.json

"coverage": "./bin/run-test.sh -c",

"bump": "./bin/run-bump.sh",

"closure": "./node_modules/.bin/closure-npc"

"test": "gulp test",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

JustinBeckwith reviewed Jun 23, 2017

View reviewed changes

.travis.yml Outdated

- '8'

script:

- ./bin/run-test.sh -c

- gulp && ./bin/run-test.sh -c

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

JustinBeckwith reviewed Jun 23, 2017

View reviewed changes

package.json

@@ -45,11 +54,11 @@

"split": "^1.0.0"

},

"scripts": {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

DominicKramer added 2 commits June 23, 2017 13:41

Add an npm build script that runs gulp

871e7d6

Update appveyor to use npm run build

6aa4904

This is used instead of invoking `gulp` directly.

matthewloring reviewed Jun 23, 2017

View reviewed changes

tsconfig.json

"allowUnreachableCode": false,

"allowUnusedLabels": false,

"alwaysStrict": true,

// "declaration": true,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

ofrobots approved these changes Jun 27, 2017

View reviewed changes

DominicKramer merged commit 8ee9583 into googleapis:master Jun 27, 2017

jmdobry removed the in progress label Jun 27, 2017

DominicKramer deleted the to-ts-prs/1-initial-gulpfile branch July 6, 2017 20:30

Conversation

DominicKramer commented Jun 23, 2017

Uh oh!

kjin left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ofrobots left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants