This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Revert "Use service name as debuggee id on gke (#275)"#278
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Jun 19, 2017
Merged
Revert "Use service name as debuggee id on gke (#275)"#278ofrobots merged 1 commit intogoogleapis:masterfrom
ofrobots merged 1 commit intogoogleapis:masterfrom
Conversation
This reverts commit d3994f8 as it breaks on non-GKE GCP enviornments. See: googleapis#275 (comment)
googlebot
added
the
cla: yes
Contributor
Author
|
TBR= @matthewloring |
DominicKramer
added a commit
to DominicKramer/cloud-debug-nodejs
that referenced
this pull request
Jun 23, 2017
commit 69106322b587bc6152199cdc0ec9b70f47afba03 Author: Dominic Kramer <[email protected]> Date: Mon Jun 19 13:51:32 2017 -0700 Convert debuglet.ts to use Typescript classes The conversion now includes the changes in PR googleapis#278 that reverts PR googleapis#275 (Use service name as debuggee id on gke). commit afa5e7e5a5df2534e9265f01df61aed6d8b11327 Author: Dominic Kramer <[email protected]> Date: Mon Jun 19 13:48:46 2017 -0700 Rename debuglet.js to debuglet.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d3994f8 as it breaks on non-GKE GCP enviornments.
See: #275 (comment)