This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Use FUNCTION_NAME as service id on GCF#274
Merged
matthewloring merged 1 commit intogoogleapis:masterfrom Jun 8, 2017
matthewloring:functions
Merged
Use FUNCTION_NAME as service id on GCF#274matthewloring merged 1 commit intogoogleapis:masterfrom matthewloring:functions
matthewloring merged 1 commit intogoogleapis:masterfrom
matthewloring:functions
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
Before: After: |
Contributor
|
@swalkowski: Is there a concept of 'versions' for functions? |
Contributor
|
/cc @emrekultursay in case you have thoughts in service identification for Cloud Functions. |
ofrobots
reviewed
Jun 7, 2017
src/agent/debuglet.js
Outdated
| service: process.env.GAE_SERVICE || process.env.GAE_MODULE_NAME || | ||
| process.env.FUNCTION_NAME, | ||
| version: process.env.GAE_VERSION || process.env.GAE_MODULE_VERSION || | ||
| 'unversioned', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@ofrobots: No, functions are unversioned at the moment. |
ofrobots
approved these changes
Jun 8, 2017
DominicKramer
approved these changes
Jun 8, 2017
src/agent/debuglet.js
Outdated
| serviceContext: { | ||
| service: process.env.GAE_SERVICE || process.env.GAE_MODULE_NAME, | ||
| version: process.env.GAE_VERSION || process.env.GAE_MODULE_VERSION, | ||
| service: process.env.GAE_SERVICE || process.env.GAE_MODULE_NAME || |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
approved these changes
Jun 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.