This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Avoid repeated indexOf checks in tests#273
Merged
matthewloring merged 1 commit intogoogleapis:masterfrom Jun 7, 2017
matthewloring:regex
Merged
Avoid repeated indexOf checks in tests#273matthewloring merged 1 commit intogoogleapis:masterfrom matthewloring:regex
matthewloring merged 1 commit intogoogleapis:masterfrom
matthewloring:regex
Conversation
googlebot
added
the
cla: yes
ofrobots
approved these changes
Jun 6, 2017
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
Ah, so much more readable. LGTM with minor nit.
test/test-v8debugapi.js
Outdated
| assert(bp.status.description.format.indexOf( | ||
| 'foo.js:500') !== -1); | ||
| assert(bp.status.description.format.match( | ||
| api.messages.INVALID_LINE_NUMBER + '.*foo.js:500')); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.