This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Update truncated object message#269
Merged
matthewloring merged 3 commits intogoogleapis:masterfrom Jun 6, 2017
matthewloring:expressions
Merged
Update truncated object message#269matthewloring merged 3 commits intogoogleapis:masterfrom matthewloring:expressions
matthewloring merged 3 commits intogoogleapis:masterfrom
matthewloring:expressions
Conversation
The message has been updated to indicate that using the object in an expression will bypass truncation limits.
googlebot
added
the
cla: yes
ofrobots
suggested changes
Jun 6, 2017
| this.config_.capture.maxProperties + | ||
| '` properties were captured'}); | ||
| '` properties were captured. Use in an expression' + | ||
| ' to see all properties.'}); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
DominicKramer
suggested changes
Jun 6, 2017
Contributor
DominicKramer
left a comment
DominicKramer
left a comment
There was a problem hiding this comment.
The current message looks good to me, but I agree we should have a similar message for STRING_LIMIT_MESSAGE_INDEX before landing this.
ofrobots
approved these changes
Jun 6, 2017
| assert(item.status.description.format.indexOf('Only first') !== -1); | ||
| assert(item.status.description.format.indexOf( | ||
| 'config.capture.maxStringLength=3') !== -1); | ||
| assert(item.status.description.format.indexOf('of length 11.') !== -1); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
DominicKramer
approved these changes
Jun 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message has been updated to indicate that using the object in an
expression will bypass truncation limits.