This repository was archived by the owner on Apr 3, 2024. It is now read-only.
stringify sourceContext before concat#265
Merged
ofrobots merged 3 commits intogoogleapis:masterfrom May 18, 2017
Merged
Conversation
googlebot
added
the
cla: yes
ofrobots
added
in progress
and removed
cla: yes
matthewloring
approved these changes
May 18, 2017
Contributor
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
LGTM, could we add a test verifying reasonable uniquifiers? (I assume the old one was just printing [object Object]?)
googlebot
added
the
cla: yes
Contributor
Author
|
Yep - already added. |
src/agent/debuglet.js
Outdated
| labels) { | ||
| var uniquifier = desc + version + uid + JSON.stringify(sourceContext) + | ||
| JSON.stringify(labels); | ||
| uniquifier = crypto.createHash('sha1').update(uniquifier).digest('hex'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sourceContext changed, our uniquifier wasn't because of a bug in how we were concatenating it.
Fixes: #263