This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Relax configuration rules for agent#245
Merged
matthewloring merged 1 commit intogoogleapis:masterfrom Mar 1, 2017
matthewloring:config-warn
Merged
Relax configuration rules for agent#245matthewloring merged 1 commit intogoogleapis:masterfrom matthewloring:config-warn
matthewloring merged 1 commit intogoogleapis:masterfrom
matthewloring:config-warn
Conversation
googlebot
added
the
cla: yes
matthewloring
changed the title
ofrobots
suggested changes
Feb 28, 2017
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
I think you may want to remove the following code too: https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/blob/master/src/agent/debuglet.js#L160
With this change, we will use the option object for agent configuation if options.debug does not exist.
Contributor
Author
|
Done. |
ofrobots
approved these changes
Mar 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, we will use the option object for agent configuration if options.debug does not exist.