Add allowExpressions option by matthewloring · Pull Request #244 · googleapis/cloud-debug-nodejs

matthewloring · 2017-02-22T01:55:01Z

No description provided.

ofrobots

The README examples also need to be modified to always suggest that users set allowExpressions to true.

test/test-v8debugapi.js

+    it('should capture without values when `allowExpressions=false`', function(done) {
+      // clone a clean breakpointInFoo
+      var bp = {id: breakpointInFoo.id, location: breakpointInFoo.location};
+      config.allowExpressions = false;


test/test-debuglet.js

      debuglet.start();
    });

+    it('should reject breakpoints with conditions when allowExpressions=false',


test/test-debuglet.js

+      debuglet.start();
+    });
+
+    it('should reject breakpoints with expressions when allowExpressions=false',


src/agent/state.js

+      varTableIndex: EXPRESSIONS_DISALLOWED_INDEX
+    });
+    locals.push({
+      name: 'locals_not_available',


ofrobots

LGTM w/ nit + question?

src/agent/config.js

  description: null,

+  /**
+   * @property {boolean} Whether or not it is safe to evaluate expressions.


src/agent/state.js

  var args = [];
  var locals = [];
+  // Locals and arguments are safe to collect even when `config.allowExpressions=false`
+  // since we properly avoid inspecting interceptors and getters by default.


googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2017

matthewloring requested a review from ofrobots February 22, 2017 04:49

ofrobots suggested changes Feb 28, 2017

View reviewed changes

ofrobots approved these changes Mar 7, 2017

View reviewed changes

Add allowExpressions option

76e38f6

matthewloring merged commit 36a0c2c into googleapis:master Mar 7, 2017

matthewloring deleted the opt branch March 7, 2017 23:10

Conversation

matthewloring commented Feb 22, 2017

Uh oh!

ofrobots left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ofrobots left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants