Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Get rid of module returning a constructor#228

Merged
ofrobots merged 1 commit intogoogleapis:masterfrom
ofrobots:no-ctor
Feb 2, 2017
Merged

Get rid of module returning a constructor#228
ofrobots merged 1 commit intogoogleapis:masterfrom
ofrobots:no-ctor

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots commented Feb 2, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2017
@ofrobots
Copy link
Copy Markdown
Contributor Author

ofrobots commented Feb 2, 2017

PTAL

Copy link
Copy Markdown
Contributor

@matthewloring matthewloring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once private configuration options are documented.

@ofrobots ofrobots merged commit 7cbee73 into googleapis:master Feb 2, 2017
@ofrobots ofrobots deleted the no-ctor branch February 2, 2017 23:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants