This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Support for AppEngine Flex environment variables#221
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Jan 20, 2017
Merged
Support for AppEngine Flex environment variables#221ofrobots merged 1 commit intogoogleapis:masterfrom
ofrobots merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
kjin
reviewed
Jan 19, 2017
| .reply(200) | ||
| .get(BPS_PATH + '?success_on_timeout=true') | ||
| .times(4) | ||
| .reply(200, {breakpoints: [bp]}); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
force-pushed
the
flex-env-vars
branch
from
b899817 to
ff71d1c
Compare
matthewloring
suggested changes
Jan 20, 2017
Contributor
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
Do we want to start including yarn.lock files for all of our projects? Maybe that should be added through a separate PR?
ofrobots
force-pushed
the
flex-env-vars
branch
from
ff71d1c to
a92ccb8
Compare
Contributor
Author
|
yarn.lock dropped. |
matthewloring
approved these changes
Jan 20, 2017
Contributor
|
LGTM once the tests are green |
Contributor
Author
|
The 0.12 build needed to be restarted. Green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also try to detect the serviceContext from the environment variables.
Apologies for the style changes. Accidentally used the 'global format' short-cut in the editor. I can try and remove the style changes if necessary.