This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Remove misleading arguments/locals message#220
Merged
cristiancavalli merged 1 commit intogoogleapis:masterfrom Jan 18, 2017
Merged
Conversation
googlebot
added
the
cla: yes
cristiancavalli
force-pushed
the
fix/cristiancavalli/remove-misleading-frame-message
branch
from
43941b8 to
f8fc9e2
Compare
Contributor
Author
|
@GoogleCloudPlatform/node-team PTAL |
ofrobots
reviewed
Jan 18, 2017
src/agent/state.js
Outdated
| StateResolver.prototype.resolveFrame_ = function(frame, resolveVars) { | ||
| var noArgs = [{ | ||
| StateResolver.prototype.resolveFrame_ = function(frame, resolveVars, currentFrame, totalFrames) { | ||
| var framesExceeded = (currentFrame >= totalFrames); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
cristiancavalli
force-pushed
the
fix/cristiancavalli/remove-misleading-frame-message
branch
from
f8fc9e2 to
715aea9
Compare
Contributor
Author
|
@ofrobots thanks for the catch. |
cristiancavalli
force-pushed
the
fix/cristiancavalli/remove-misleading-frame-message
branch
from
715aea9 to
d677e5a
Compare
ofrobots
suggested changes
Jan 18, 2017
src/agent/state.js
Outdated
| var args = []; | ||
| var locals = []; | ||
| if (!underFrameCap) { | ||
| args.push(this.produceArgumentsNotAvailableMessage()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/agent/state.js
Outdated
| var locals = []; | ||
| if (!underFrameCap) { | ||
| args.push(this.produceArgumentsNotAvailableMessage()); | ||
| locals.push(this.produceLocalsNotAvailableMessage()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
cristiancavalli
force-pushed
the
fix/cristiancavalli/remove-misleading-frame-message
branch
from
d677e5a to
3e5a169
Compare
Contributor
Author
|
updated |
When within the frame capture range omit status messages declaming that arguments/locals are only captured for frames in the capture range. 01/18/2016 - Update `resolveFrame_` to have simpler implmentation with less branching.
ofrobots
approved these changes
Jan 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When within the frame capture range omit status
messages declaming that arguments/locals are only
captured for frames in the capture range.