Use mocha for end-to-end tests#212
Conversation
googlebot
added
the
cla: yes
kjin
requested review from
DominicKramer,
cristiancavalli,
matthewloring and
ofrobots
test/fixtures/fib.js
Outdated
| process.send([errorMessage]); | ||
| } | ||
| }; | ||
| sendErrorIfNotOk(debug.private_, 'debuglet has initialized'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/e2e/test-e2e.js
Outdated
| }); | ||
| }; | ||
|
|
||
| describe('@google-cloud/debug end-to-end behavior (allow 60s)', function () { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/fixtures/fib.js
Outdated
| sendErrorIfNotOk(debuggee.id, 'debuggee should have registered'); | ||
| if (ok) { | ||
| // The parent process needs to know the debuggeeId and project. | ||
| process.send(['', debuggee.id, debuggee.project]); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| assert.equal(debuggeeId, a[1]); | ||
| assert.equal(projectId, a[2]); | ||
| if (debuggeeId !== a[1] || projectId !== a[2]) { | ||
| reject(new Error('Child debuggee ID and/or project ID' + |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| afterEach(function() { | ||
| children.forEach(function (child) { | ||
| child.process.kill(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
LGTM once things are passing for 0.12
kjin
force-pushed
the
mocha-e3e
branch
2 times, most recently
from
a22178c to
de9172a
Compare
|
Still fixing tests - since E2E tests fail. |
test/standalone/test-capture-time.js
Outdated
| @@ -0,0 +1,109 @@ | |||
| // /** | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
4 participants
Turned
test-breakpoints.jsandtest-log-throttling.jsinto mocha tests in a new filetest-e2e.js. This involved splitting off the debuggee into a separate file (fib.js).Changes to the tests themselves are: