This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Merged
Conversation
googlebot
added
the
cla: yes
matthewloring
approved these changes
Dec 23, 2016
Contributor
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
LGTM with wording change.
README.md
Outdated
| ### Google Container Engine | ||
|
|
||
| Container Engine nodes need to also be created with the `cloud-platform` scope, which is configurable during cluster creation. Alternatively, you can follow the instructions for using a service account under [running elsewhere](#running-elsewhere). It's recommended that you store the service account credentials as [Kubernetes Secret](http://kubernetes.io/v1.1/docs/user-guide/secrets.html). | ||
| Stackdriver debugger agent should work out of the box if you code running on Google Cloud Platform, just make sure that the [Stackdriver Debugger API][debugger-api] is enabled on your project (this is the default). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kjin
approved these changes
Dec 23, 2016
* We no longer need cloud-platform scope. * The API has consolidated to cloud_debugger as the single scope. cloud_debugletcontroller doesn't seem to be a valid scope anymore. * Simplify readme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloud_debugletcontroller doesn't seem to be a valid scope anymore.