Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Fix flakiness in test-debuglet.js#207

Merged
ofrobots merged 1 commit intogoogleapis:masterfrom
ofrobots:disabled-test
Dec 22, 2016
Merged

Fix flakiness in test-debuglet.js#207
ofrobots merged 1 commit intogoogleapis:masterfrom
ofrobots:disabled-test

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots commented Dec 22, 2016

  • A setTimeout that doesn't dominate the async done() path causes flakiness.
  • Improve the test to be more on-topic.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2016
matthewloring
matthewloring suggested changes Dec 22, 2016
View reviewed changes
test/standalone/test-debuglet.js Outdated
});

debuglet.once('registered', function(id) {
assert.ok('gotDisabled');

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ofrobots
fix flakiness in test-debuglet.js
697ea86 
* A setTimeout that doesn't dominate the async done() path causes
  flakiness.
* Improve the test to be more on-topic.
@ofrobots ofrobots merged commit a680d87 into googleapis:master Dec 22, 2016
@ofrobots ofrobots deleted the disabled-test branch December 22, 2016 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@matthewloring matthewloring matthewloring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ofrobots @matthewloring @googlebot