This repository was archived by the owner on Apr 3, 2024. It is now read-only.
credentials accepted in options only now#200
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Dec 20, 2016
Merged
Conversation
ofrobots
added
the
semver: major
googlebot
added
the
cla: yes
ofrobots
changed the title
matthewloring
suggested changes
Dec 19, 2016
src/index.js
Outdated
|
|
||
| if (config.keyFilename || config.credentials || config.projectId) { | ||
| throw new Error('keyFilename, projectId or credentials should be provided' + | ||
| ' in the module options'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/nocks.js
Outdated
| oauth2: nockOAuth2, | ||
| numericProjectId: nockNumericProjectId, | ||
| register: nockRegister | ||
| }; No newline at end of file |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
changed the title
matthewloring
suggested changes
Dec 20, 2016
| require('@google/cloud-debug').start(); | ||
| ```js | ||
| // Require and start in the startup of your application: | ||
| var debug = require('@google-cloud/debug')(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| [service-account]: https://console.cloud.google.com/apis/credentials/serviceaccountkey | ||
| [npm-image]: https://img.shields.io/npm/v/@google/cloud-debug.svg | ||
| [npm-url]: https://npmjs.org/package/@google/cloud-debug | ||
| [npm-image]: https://img.shields.io/npm/v/@google-cloud/debug.svg |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
matthewloring
approved these changes
Dec 20, 2016
Contributor
|
LGTM once the unit tests are passing. |
ofrobots
force-pushed
the
creds-in-options
branch
2 times, most recently
from
5f8542e to
7eeef47
Compare
ofrobots
force-pushed
the
creds-in-options
branch
from
fad2a3d to
2240848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.