Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Fill in unimplemented tests#199

Merged
matthewloring merged 1 commit intogoogleapis:masterfrom
matthewloring:tests
Dec 19, 2016
Merged

Fill in unimplemented tests#199
matthewloring merged 1 commit intogoogleapis:masterfrom
matthewloring:tests

Conversation

@matthewloring
Copy link
Copy Markdown
Contributor

@matthewloring matthewloring commented Dec 17, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2016
ofrobots
ofrobots suggested changes Dec 19, 2016
View reviewed changes
test/standalone/test-debuglet.js
debuglet = new Debuglet(fakeDebug, config, logger);

debuglet.once('initError', function(err) {
assert(err);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/standalone/test-debuglet.js
});

it('should de-activate when the server responds with isDisabled');
it('should de-activate when the server responds with isDisabled', function(done) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/standalone/test-debuglet.js
debuglet.start();
});

it('should re-register when registration expires', function(done) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

ofrobots
ofrobots approved these changes Dec 19, 2016
View reviewed changes
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ nits.

test/standalone/test-debuglet.js Outdated
});

debuglet.once('registered', function(id) {
assert(id === DEBUGGEE_ID);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/standalone/test-debuglet.js Outdated
debuglet.once('registered', function(id) {
assert(id === DEBUGGEE_ID);
setImmediate(function() {
assert(debuglet.fetcherActive_);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/standalone/test-debuglet.js Outdated
});

setTimeout(function() {
assert(!debuglet.fetcherActive_);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@matthewloring matthewloring merged commit 4dc2aa0 into googleapis:master Dec 19, 2016
@matthewloring matthewloring deleted the tests branch December 19, 2016 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kjin kjin Awaiting requested review from kjin

@cristiancavalli cristiancavalli Awaiting requested review from cristiancavalli

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

1 more reviewer

@ofrobots ofrobots ofrobots approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewloring @ofrobots @googlebot