This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Refactor debuggee state out of controller and make Controller a ServiceObject#195
Merged
ofrobots merged 3 commits intogoogleapis:masterfrom Dec 16, 2016
Merged
Refactor debuggee state out of controller and make Controller a ServiceObject#195ofrobots merged 3 commits intogoogleapis:masterfrom
ofrobots merged 3 commits intogoogleapis:masterfrom
Conversation
Contributor
ofrobots
commented
Dec 16, 2016
ofrobots
commented
- Try to run system and e2e tests on developer builds as well
- make Controller a ServiceObject
- Remove debuggee state from controller class
googlebot
added
the
cla: yes
| /** @private {string} debuggee id provided by the server once registered */ | ||
| this.debuggeeId_ = null; | ||
| common.ServiceObject.call(this, { | ||
| parent: debug, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
matthewloring
approved these changes
Dec 16, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.