This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Switch from findit to findit2#183
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Dec 9, 2016
Merged
Conversation
https://www.npmjs.com/package/findit2 seems to fix a few open bugs with findit, which doesn't seem to be maintained anymore. Furthermore, this fixes the issue that findit was intermittently failing to find all the files on windows causing the AppVeyor builds to fail.
googlebot
added
the
cla: yes
Contributor
Author
|
PTAL. AppVeyor is green again! |
matthewloring
approved these changes
Dec 9, 2016
Contributor
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
findit and findit2 both don't seem to have as large a user base as walker (3k downloads/day from the findits v. 40k for walker). None of these modules have seen releases in the last few years so maybe it doesn't matter anyways.
Contributor
Author
|
However, |
Contributor
|
Yup, sounds good! |
Contributor
|
I second using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.npmjs.com/package/findit2 seems to fix a few open bugs with
findit, which doesn't seem to be maintained anymore. Furthermore, this
fixes the issue that findit was intermittently failing to find all the
files on windows causing the AppVeyor builds to fail.