This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix race condition with log points#181
Merged
ofrobots merged 1 commit intogoogleapis:masterfrom Dec 9, 2016
Merged
Conversation
Cannot assume that listeners[num] would still be valid across an async hop. It is possible that someone has cleared the log point across the timeout.
Contributor
Author
|
R=@matthewloring. PTAL. |
Contributor
Author
|
Oooh.. github has new UI for nominating reviewers.. |
matthewloring
approved these changes
Dec 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cannot assume that listeners[num] would still be valid across an async
hop. It is possible that someone has cleared the log point across the
timeout.