Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Now status messages include config values#177

Merged
DominicKramer merged 1 commit intogoogleapis:masterfrom
DominicKramer:feature/show-values-in-status-messages
Nov 19, 2016
Merged

Now status messages include config values#177
DominicKramer merged 1 commit intogoogleapis:masterfrom
DominicKramer:feature/show-values-in-status-messages

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

Now if a status message referes to a configuration option the
syntax configname=configvalue will be used to specify the
configuration option's name as well as its value.

Also deleted the item at the DATA_LIMIT_MESSAGE_INDEX index
in the MESSAGE_TABLE since it is no longer needed.

Now if a status message referes to a configuration option the
syntax `configname=configvalue` will be used to specify the
configuration option's name as well as its value.

Also deleted the item at the `DATA_LIMIT_MESSAGE_INDEX` index
in the `MESSAGE_TABLE` since it is no longer needed.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2016
@DominicKramer
Copy link
Copy Markdown
Contributor Author

PTAL

Copy link
Copy Markdown
Contributor

@matthewloring matthewloring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DominicKramer DominicKramer merged commit d666c99 into googleapis:master Nov 19, 2016
@DominicKramer DominicKramer deleted the feature/show-values-in-status-messages branch November 20, 2016 02:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants