This repository was archived by the owner on Apr 3, 2024. It is now read-only.
improve UX for truncated objects properties#175
Merged
ofrobots merged 3 commits intogoogleapis:masterfrom Nov 15, 2016
Merged
Conversation
googlebot
added
the
cla: yes
Change how we indicate that an object with too many properties has been truncated on our state captures. Instead of a non-error StatusMessage add an extra member with no value / varTableIndex. This matches how the Java agent deals with this situation.
ofrobots
force-pushed
the
truncation-messages-ux
branch
from
ed59c5b to
855d3c1
Compare
| 'Only first') !== -1); | ||
| assert(!foo.status.isError); | ||
| // should have 1 element + truncation message. | ||
| assert.equal(fooVal.members.length, 2); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Except for the comment I had about what we should display in the case when the |
ofrobots
changed the title
test/test-v8debugapi.js
Outdated
| var envVal = bp.variableTable[procEnv.varTableIndex]; | ||
| envVal.members.forEach(function(member) { | ||
| assert(bp.variableTable[member.varTableIndex].status.isError); | ||
| if (member.varTableIndex) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM with question and passing CI |
ofrobots
force-pushed
the
truncation-messages-ux
branch
from
ecfdb16 to
3a491b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how we indicate that an object with too many properties has been
truncated on our state captures. Instead of a non-error StatusMessage
add an extra member with no value / varTableIndex. This matches how the
Java agent deals with this situation.
Original:
Now:
and:
R= @DominicKramer @cristiancavalli