This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Correct the status shown if maxDataSize is reached#173
Merged
DominicKramer merged 1 commit intogoogleapis:masterfrom Nov 11, 2016
Merged
Correct the status shown if maxDataSize is reached#173DominicKramer merged 1 commit intogoogleapis:masterfrom
DominicKramer merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
PTAL |
matthewloring
approved these changes
Nov 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a watched expression is collected that causes the
config.capture.maxDataSizelimit to be reached, local variables may not be collected, but the status message associated with the local variable would be incorrect. In particular, if the local was an array, the message would describe that only the firstconfig.capture.maxPropertiesitems were captured. This PR corrects this so that the status message is instead 'Max data size reached'.