Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Make E2E tests ScopeMirror aware#149

Merged
cristiancavalli merged 2 commits intomasterfrom
e2e-tests-scope-aware
Aug 20, 2016
Merged

Make E2E tests ScopeMirror aware#149
cristiancavalli merged 2 commits intomasterfrom
e2e-tests-scope-aware

Conversation

@cristiancavalli
Copy link
Copy Markdown
Contributor

Add semver to dependencies for e2e tests. Add version
check in breakpoint fetch and compare to determine whether
or not to look in locals or arguments for target variable.

Fixes the build errors we've been receiving on pushes.

Add `semver` to dependencies for node version checking.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2016
Add version check in breakpoint fetch and compare
for determination of local or argument array value
lookups. Update `.find` call to use `.matches` property
shorthand.
@cristiancavalli
Copy link
Copy Markdown
Contributor Author

@matthewloring @ofrobots PTAL

@matthewloring
Copy link
Copy Markdown
Contributor

LGTM

@cristiancavalli cristiancavalli merged commit 198fb1e into master Aug 20, 2016
@cristiancavalli cristiancavalli deleted the e2e-tests-scope-aware branch August 20, 2016 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants