Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

fix: increase capture limit to allow Windows tests to pass#1188

Merged
mctavish merged 2 commits intogoogleapis:mainfrom
mctavish:fix-windows-tests
Dec 20, 2023
Merged

fix: increase capture limit to allow Windows tests to pass#1188
mctavish merged 2 commits intogoogleapis:mainfrom
mctavish:fix-windows-tests

Conversation

@mctavish
Copy link
Copy Markdown
Contributor

@mctavish mctavish commented Dec 20, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1187 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Dec 20, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd4dee0) 61.72% compared to head (7992249) 61.72%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1188   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files          17       17           
  Lines        1309     1309           
  Branches      257      257           
=======================================
  Hits          808      808           
  Misses        447      447           
  Partials       54       54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mctavish mctavish marked this pull request as ready for review December 20, 2023 16:41
@mctavish mctavish requested review from a team December 20, 2023 16:41
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2023
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2023
@mctavish mctavish merged commit 728b90e into googleapis:main Dec 20, 2023
@release-please release-please bot mentioned this pull request Dec 20, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 2, 2024
@release-please
chore(main): release 9.0.0 (#1162)
8bb6588 
🤖 I have created a release *beep* *boop*
---


## [9.0.0](https://togithub.com/googleapis/cloud-debug-nodejs/compare/v8.0.0...v9.0.0) (2023-12-21)


### ⚠ BREAKING CHANGES

* upgrade to node 14 ([#1160](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1160))

### Bug Fixes

* **deps:** Update dependency firebase-admin to v12 ([#1185](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1185)) ([f757913](https://togithub.com/googleapis/cloud-debug-nodejs/commit/f7579138f9cb9f6a7d967bf7c57dbef5966259d8))
* Increase capture limit to allow Windows tests to pass ([#1188](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1188)) ([728b90e](https://togithub.com/googleapis/cloud-debug-nodejs/commit/728b90ebdd6f73081261019f3d4d2c4ce121bea6))
* Remove unused second parameter ([#1161](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1161)) ([f8815fc](https://togithub.com/googleapis/cloud-debug-nodejs/commit/f8815fce6b64c73e0357873cdf1b4b752887acb1))


### Miscellaneous Chores

* Upgrade to node 14 ([#1160](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1160)) ([bd45473](https://togithub.com/googleapis/cloud-debug-nodejs/commit/bd45473bda6d9f87adcbc4752f773e99a3fbcf89))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows unit tests are broken

2 participants

@mctavish @sofisl