Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

docs: add documentation for common config parameters#1172

Merged
gcf-merge-on-green[bot] merged 4 commits intogoogleapis:mainfrom
mctavish:expressions-doc
Oct 2, 2023
Merged

docs: add documentation for common config parameters#1172
gcf-merge-on-green[bot] merged 4 commits intogoogleapis:mainfrom
mctavish:expressions-doc

Conversation

@mctavish
Copy link
Copy Markdown
Contributor

@mctavish mctavish commented Sep 25, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1008 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Sep 25, 2023
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 25, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d477d1e) 61.72% compared to head (4d3e1b9) 61.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files          17       17           
  Lines        1309     1309           
  Branches      257      257           
=======================================
  Hits          808      808           
  Misses        447      447           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

@mctavish mctavish marked this pull request as ready for review September 25, 2023 18:37
@mctavish mctavish requested review from a team September 25, 2023 18:37
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 25, 2023
@mctavish mctavish requested a review from haroonc September 29, 2023 15:03
@mctavish mctavish added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1f772d2 into googleapis:main Oct 2, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allowExpressions configuration option not documented

2 participants