Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

docs: remove content about the shut down Cloud Debugger service#1149

Merged
mctavish merged 3 commits intogoogleapis:mainfrom
mctavish:firebase-docs
Jun 6, 2023
Merged

docs: remove content about the shut down Cloud Debugger service#1149
mctavish merged 3 commits intogoogleapis:mainfrom
mctavish:firebase-docs

Conversation

@mctavish
Copy link
Copy Markdown
Contributor

@mctavish mctavish commented Jun 6, 2023

This PR updates the README content to reflect the changes made for #1143

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Jun 6, 2023
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

@mctavish mctavish marked this pull request as ready for review June 6, 2023 15:11
@mctavish mctavish requested review from a team and jasonborg June 6, 2023 15:11
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ed8fb2) 54.51% compared to head (ecc9e67) 54.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   54.51%   54.51%           
=======================================
  Files          18       18           
  Lines        1495     1495           
  Branches      290      290           
=======================================
  Hits          815      815           
  Misses        626      626           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@jasonborg jasonborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other parts of the readme could also use updating if you're able to, such as references to the Cloud Debugger and the Before you begin section that says to `Enable the Cloud Debugger API1

@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@mctavish mctavish merged commit 95c9078 into googleapis:main Jun 6, 2023
@mctavish mctavish deleted the firebase-docs branch June 6, 2023 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants