Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

feat: add stop function to allow shutting down the debug agent#1147

Merged
mctavish merged 6 commits intogoogleapis:mainfrom
mctavish:add-stop
Jun 5, 2023
Merged

feat: add stop function to allow shutting down the debug agent#1147
mctavish merged 6 commits intogoogleapis:mainfrom
mctavish:add-stop

Conversation

@mctavish
Copy link
Copy Markdown
Contributor

@mctavish mctavish commented Jun 1, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1148 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Jun 1, 2023
@mctavish mctavish changed the title Add stop feat: add stop function to allow shutting down the debug agent Jun 1, 2023
@mctavish mctavish added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 1, 2023
@mctavish mctavish marked this pull request as ready for review June 1, 2023 21:39
@mctavish mctavish requested review from a team and jasonborg June 1, 2023 21:39
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 89.47% and no project coverage change.

Comparison is base (c5bbb4e) 73.27% compared to head (a89ef6e) 73.27%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1147   +/-   ##
=======================================
  Coverage   73.27%   73.27%           
=======================================
  Files          20       20           
  Lines        1605     1624   +19     
  Branches      314      319    +5     
=======================================
+ Hits         1176     1190   +14     
- Misses        343      347    +4     
- Partials       86       87    +1
Impacted Files Coverage Δ
src/agent/firebase-controller.ts 65.83% <ø> (ø)
src/index.ts 77.77% <33.33%> (-5.56%) ⬇️
src/agent/debuglet.ts 78.35% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mctavish mctavish added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2023
@mctavish mctavish merged commit c292200 into googleapis:main Jun 5, 2023
@release-please release-please bot mentioned this pull request Jun 5, 2023
Merged
@mctavish mctavish deleted the add-stop branch June 5, 2023 18:35
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 6, 2023
@release-please
chore(main): release 8.0.0 (#1146)
83183e2 
🤖 I have created a release *beep* *boop*
---


## [8.0.0](https://togithub.com/googleapis/cloud-debug-nodejs/compare/v7.2.2...v8.0.0) (2023-06-06)


### ⚠ BREAKING CHANGES

* Remove support for deprecated Cloud Debugger API. ([#1144](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1144))

### Features

* Add stop function to allow shutting down the debug agent ([#1147](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1147)) ([c292200](https://togithub.com/googleapis/cloud-debug-nodejs/commit/c292200ff83660d7f9c509af2c45c5e6a1565011))
* Remove support for deprecated Cloud Debugger API. ([#1144](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1144)) ([7ed8fb2](https://togithub.com/googleapis/cloud-debug-nodejs/commit/7ed8fb2a16bea36903fbc72ebc066b19bb10143c))


### Bug Fixes

* Unblock compodoc page generation ([#1145](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1145)) ([c5bbb4e](https://togithub.com/googleapis/cloud-debug-nodejs/commit/c5bbb4ead353614a548e1f962c9fdf3cc6ea9845))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jasonborg jasonborg jasonborg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Agent may prevent processes from shutting down when using Firebase backend

3 participants

@mctavish @jasonborg @yoshi-kokoro