This repository was archived by the owner on Apr 3, 2024. It is now read-only.
chore: remove dead code for supporting node < 10#1141
Merged
mctavish merged 2 commits intogoogleapis:mainfrom May 25, 2023
Merged
chore: remove dead code for supporting node < 10#1141mctavish merged 2 commits intogoogleapis:mainfrom
mctavish merged 2 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
size: l
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 65.68% 72.77% +7.08%
==========================================
Files 21 20 -1
Lines 1798 1605 -193
Branches 355 314 -41
==========================================
- Hits 1181 1168 -13
+ Misses 530 346 -184
- Partials 87 91 +4
☔ View full report in Codecov by Sentry. |
mctavish
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
jasonborg
approved these changes
May 25, 2023
mctavish
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
mctavish
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup change that removes code that hasn't been used since before Node 10. No functional changes expected as at the moment we only support Node >= 12.