Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

feat: add error handling to firebase controller.#1116

Merged
gcf-merge-on-green[bot] merged 7 commits intogoogleapis:mainfrom
mctavish:improvements
Dec 2, 2022
Merged

feat: add error handling to firebase controller.#1116
gcf-merge-on-green[bot] merged 7 commits intogoogleapis:mainfrom
mctavish:improvements

Conversation

@mctavish
Copy link
Copy Markdown
Contributor

@mctavish mctavish commented Dec 1, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1115 🦕

@mctavish mctavish requested review from a team December 1, 2022 18:44
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Dec 1, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2022

Codecov Report

Base: 65.84% // Head: 65.74% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (2034588) compared to base (640708c).
Patch coverage: 70.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
- Coverage   65.84%   65.74%   -0.11%     
==========================================
  Files          19       19              
  Lines        1742     1769      +27     
  Branches      352      354       +2     
==========================================
+ Hits         1147     1163      +16     
- Misses        508      520      +12     
+ Partials       87       86       -1     
Impacted Files Coverage Δ
src/agent/firebase-controller.ts 66.00% <70.00%> (-2.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mctavish mctavish requested a review from jasonborg December 1, 2022 20:49
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2022
@mctavish mctavish added the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit a188e34 into googleapis:main Dec 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 9, 2022
🤖 I have created a release *beep* *boop*
---


## [7.2.0](https://togithub.com/googleapis/cloud-debug-nodejs/compare/v7.1.1...v7.2.0) (2022-12-09)


### Features

* Add active debuggee support ([#1121](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1121)) ([a421509](https://togithub.com/googleapis/cloud-debug-nodejs/commit/a421509d7c616a4ed48302498886ffa66bfefad9))
* Add error handling to firebase controller. ([#1116](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1116)) ([a188e34](https://togithub.com/googleapis/cloud-debug-nodejs/commit/a188e347131168d21d01f77267863e53ae1043a8))


### Bug Fixes

* Correctly send labels on register calls. ([#1118](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1118)) ([007cbbd](https://togithub.com/googleapis/cloud-debug-nodejs/commit/007cbbd3df765b06978aa5604bcbdb4925cf725e))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add error handling to the firebase controller

2 participants