This repository was archived by the owner on Apr 3, 2024. It is now read-only.
chore: fix presubmit failures by adjusting docs and pinning a system-test dependency#1113
Merged
mctavish merged 3 commits intogoogleapis:mainfrom Nov 17, 2022
Merged
chore: fix presubmit failures by adjusting docs and pinning a system-test dependency#1113mctavish merged 3 commits intogoogleapis:mainfrom
mctavish merged 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
size: xs
Codecov ReportBase: 65.79% // Head: 65.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
+ Coverage 65.79% 65.84% +0.05%
==========================================
Files 21 19 -2
Lines 1751 1742 -9
Branches 352 352
==========================================
- Hits 1152 1147 -5
+ Misses 512 508 -4
Partials 87 87
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mctavish
changed the title
mctavish
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
size: s
jasonborg
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci/kokoro: System test is broken without this change.
Newer versions of typescript prevent express-serve-static-core from building properly, which blocks PRs in this repo from being submitted. Given the fact that the typescript version is largely irrelevant for the sample app, this pinning to a specific version is the simplest way to unblock submission of PRs.
Also includes quick change to make the readme easier to read and to help out linkinator, without which ci/docs will fail.