Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

docs: add custom readme content#1100

Merged
mctavish merged 7 commits intogoogleapis:mainfrom
mctavish:readme
Sep 9, 2022
Merged

docs: add custom readme content#1100
mctavish merged 7 commits intogoogleapis:mainfrom
mctavish:readme

Conversation

@mctavish
Copy link
Copy Markdown
Contributor

@mctavish mctavish commented Aug 11, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1086 🦕

@mctavish mctavish requested review from a team August 11, 2022 17:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Aug 11, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1100 (5c4e4e4) into main (bbaa42e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   65.79%   65.79%           
=======================================
  Files          21       21           
  Lines        1751     1751           
  Branches      352      352           
=======================================
  Hits         1152     1152           
  Misses        512      512           
  Partials       87       87           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown

@fatoboist fatoboist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions. Definitely need to state what each code sample is doing even if you think it's obvious from the heading before it :)

@mctavish mctavish requested review from fatoboist and jasonborg and removed request for fatoboist September 1, 2022 21:54
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2022
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@mctavish mctavish merged commit 92176b0 into googleapis:main Sep 9, 2022
@mctavish mctavish deleted the readme branch September 9, 2022 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add agent usage information to the README.

3 participants