This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: use debuglet's logger in the controller.#1077
Merged
mctavish merged 5 commits intogoogleapis:firebase-backendfrom May 11, 2022
Merged
fix: use debuglet's logger in the controller.#1077mctavish merged 5 commits intogoogleapis:firebase-backendfrom
mctavish merged 5 commits intogoogleapis:firebase-backendfrom
Conversation
This will provide a consistent log level throughout the codebase.
product-auto-label
bot
added
size: m
Codecov Report
@@ Coverage Diff @@
## firebase-backend #1077 +/- ##
====================================================
- Coverage 66.13% 66.11% -0.02%
====================================================
Files 21 21
Lines 1751 1750 -1
Branches 352 352
====================================================
- Hits 1158 1157 -1
Misses 510 510
Partials 83 83
Continue to review full report at Codecov.
|
jasonborg
approved these changes
May 11, 2022
Contributor
jasonborg
left a comment
jasonborg
left a comment
There was a problem hiding this comment.
My only comment is I was expecting to see a similar change to pass the logger into the FirebaseController, but I see it uses 'const debuglog = util.debuglog('cdbg.firebase');'
We're ok with this for now?
Contributor
Author
|
Okay for now. The logs in the firebase controller are explicitly debug
logs that Ben suggested I use instead of console.log during development.
We'll revisit what logging should be present later.
…On Wed, May 11, 2022 at 2:52 PM jasonborg ***@***.***> wrote:
***@***.**** approved this pull request.
My only comment is I was expecting to see a similar change to pass the
logger into the FirebaseController, but I see it uses 'const debuglog =
util.debuglog('cdbg.firebase');'
We're ok with this for now?
—
Reply to this email directly, view it on GitHub
<#1077 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOWYSHLZSD7G3SOPAPWH5TVJP6XHANCNFSM5VV23SDA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will ensure consistent logging behaviour across the codebase.