Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

fix: Fix and re-enable previously broken tests#1075

Merged
mctavish merged 3 commits intogoogleapis:firebase-backendfrom
mctavish:firebase-backend-dev
May 11, 2022
Merged

fix: Fix and re-enable previously broken tests#1075
mctavish merged 3 commits intogoogleapis:firebase-backendfrom
mctavish:firebase-backend-dev

Conversation

@mctavish
Copy link
Copy Markdown
Contributor

@mctavish mctavish commented May 10, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1072 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels May 10, 2022
@mctavish mctavish marked this pull request as ready for review May 10, 2022 13:57
@mctavish mctavish requested review from a team May 10, 2022 13:57
@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (firebase-backend@842690f). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             firebase-backend    #1075   +/-   ##
===================================================
  Coverage                    ?   66.13%           
===================================================
  Files                       ?       21           
  Lines                       ?     1751           
  Branches                    ?      352           
===================================================
  Hits                        ?     1158           
  Misses                      ?      510           
  Partials                    ?       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842690f...756c8a6. Read the comment docs.

@mctavish mctavish requested a review from jasonborg May 10, 2022 18:19
@mctavish
Copy link
Copy Markdown
Contributor Author

mctavish commented May 10, 2022

@jasonborg Please also review 842690f

jasonborg
jasonborg approved these changes May 10, 2022
View reviewed changes
@mctavish mctavish merged commit dd61d35 into googleapis:firebase-backend May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jasonborg jasonborg jasonborg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mctavish @jasonborg