This repository was archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
This repository was archived by the owner on Apr 3, 2024. It is now read-only.
sourceContext typings are incorrect #541
Copy link
Copy link
Closed
Labels
api: clouddebuggerIssues related to the googleapis/cloud-debug-nodejs API.Issues related to the googleapis/cloud-debug-nodejs API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
The typings for the sourceContext config appear to be incorrect.
sourceContext: {
url: 'mygiturl',
revisionId: 'abc',
}
➡️ Error: Invalid JSON payload received. Unknown name "url" at 'debuggee.source_contexts[0]': Cannot find field. in stackdriver logs
sourceContext: {
git: {
url: 'mygiturl',
revisionId: 'abc',
}
}
➡️ works as expected
I'm presuming these nested objects are going to be required for the other source context options too?
Source:
cloud-debug-nodejs/src/agent/config.ts
Line 154 in d0b0363
| sourceContext?: CloudRepoSourceContext|CloudWorkspaceSourceContext| |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
api: clouddebuggerIssues related to the googleapis/cloud-debug-nodejs API.Issues related to the googleapis/cloud-debug-nodejs API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.