Switch to sha1 and add a TODO.

mctavish · mctavish · commit e4d069608e55 · 2022-07-26T10:38:51.000-04:00
diff --git a/src/agent/firebase-controller.ts b/src/agent/firebase-controller.ts
@@ -133,8 +133,10 @@ export class FirebaseController implements Controller {
 
     // Calculate the debuggee id as the hash of the object.
     // This MUST be consistent across all debuggee instances.
+    // TODO: JSON.stringify may provide different strings if labels are added
+    // in different orders.
     const debuggeeHash = crypto
-      .createHash('md5')
+      .createHash('sha1')
       .update(JSON.stringify(debuggee))
       .digest('hex');
     this.debuggeeId = `d-${debuggeeHash.substring(0, 8)}`;
diff --git a/test/test-firebase-controller.ts b/test/test-firebase-controller.ts
@@ -150,9 +150,9 @@ describe('Firebase Controller', () => {
   describe('register', () => {
     it('should get a debuggeeId', done => {
       const db = new MockDatabase();
-      // Debuggee Id is based on the md5 hash of the json representation of
+      // Debuggee Id is based on the sha1 hash of the json representation of
       // the debuggee.
-      const debuggeeId = 'd-e1662bd7';
+      const debuggeeId = 'd-b9dbb5e7';
       const controller = new FirebaseController(
         db as {} as firebase.database.Database
       );
