Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Commit e108967

Browse files
fix: Skip 32bit platform warning starting on 8.9 (#351)
As asnyc stack traces will not be turned on by default statring with node 8.9.0, The warning message of 'async stack trace is not available on 32 bit platform' no longer emitted. We will not emit this elaboration to users.
1 parent 185f1c2 commit e108967

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/test-debuglet.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,8 @@ describe('Debuglet', function() {
345345
// TODO: Handle the case where debuglet.debuggee is undefined
346346
assert.equal((debuglet.debuggee_ as Debuggee).project, projectId);
347347
const arch = process.arch;
348-
if (semver.satisfies(process.version, '>=8.5') &&
348+
if (semver.satisfies(process.version, '>=8.5.0') &&
349+
semver.satisfies(process.version, '<8.9.0') &&
349350
(arch === 'ia32' || arch === 'x86') &&
350351
process.env.GCLOUD_USE_INSPECTOR) {
351352
assert(logText.includes(utils.messages.ASYNC_TRACES_WARNING));

0 commit comments

Comments
 (0)