Cleanup todos

Matt Loring · Matt Loring · commit a78287553250 · 2016-01-13T12:22:00.000-08:00
diff --git a/lib/debuglet.js b/lib/debuglet.js
@@ -138,8 +138,6 @@ Debuglet.prototype.scheduleRegistration_ = function(seconds) {
     that.logger_.error('Failed to re-register debuggee: ' + err);
     that.logger_.error('Disabling gcloud debuglet');
     that.stop(); // fatal error
-    // TODO: unless this is a configuration/fatal problem, maybe we should try
-    // again after a larger delay?
   }
 
   setTimeout(function() {
diff --git a/lib/scanner.js b/lib/scanner.js
@@ -67,8 +67,6 @@ function computeStats(fileList, callback) {
       if (pending === 0) {
         // Sort the hashes to get a deterministic order as the files may not
         // be in the same order each time we scan the disk.
-        // TODO: it might be faster to sort if we had a binary hash instead
-        // of a string.
         var buffer = hashes.sort().join();
         var sha1 = crypto.createHash('sha1').update(buffer).digest('hex');
         callback(null, 'SHA1-' + sha1, statistics);
diff --git a/lib/state.js b/lib/state.js
@@ -21,7 +21,6 @@ module.exports = {
   evaluate: evaluate
 };
 
-//var util = require('util');
 var assert = require('assert');
 
 var StatusMessage = require('./apiclasses.js').StatusMessage;
@@ -332,11 +331,7 @@ StateResolver.prototype.resolveVariable_ = function(name, value) {
 };
 
 StateResolver.prototype.getVariableIndex_ = function(value) {
-  // TODO(ofrobots): Once V8 de-optimization issue is fixed, come back and
-  // re-evaluate this method. The naïve indexOf scan be sped up by monkey
-  // patching the value mirror object with an index. Not sure if it is
-  // significantly faster to be worth doing at this point.
-   var idx = this.rawVariableTable_.indexOf(value);
+  var idx = this.rawVariableTable_.indexOf(value);
   if (idx === -1) {
     idx = this.storeObjectToVariableTable_(value);
   }
diff --git a/lib/v8debugapi.js b/lib/v8debugapi.js
@@ -143,7 +143,6 @@ module.exports.create = function(logger_, config_, fileStats_) {
                 messages.ERROR_COMPILING_CONDITION);
           }
         }
-        // TODO: more robust file finding of compiled files
         scriptPath = scriptPath.substr(0, scriptPath.lastIndexOf('.')) + '.js';
         var mappingUrl = scriptPath + '.map';
 
@@ -231,7 +230,6 @@ module.exports.create = function(logger_, config_, fileStats_) {
   function setInternal(breakpoint, scriptPath, compile, cb) {
     // Parse and validate conditions and watch expressions for correctness and
     // immutability
-    // TODO: make it an option for users to disable validation
     var ast = null;
     if (breakpoint.condition) {
       var acorn = require('acorn');
@@ -273,9 +271,6 @@ module.exports.create = function(logger_, config_, fileStats_) {
         StatusMessage.BREAKPOINT_SOURCE_LOCATION,
         messages.SOURCE_FILE_AMBIGUOUS);
     }
-    // TODO: need to cleanup the above
-    // TODO: need test coverage for the above
-    // TODO: work with debug server to come up with a more robust solution
 
     if (breakpoint.location.line >= fileStats[matchingScript].lines) {
       return setErrorStatusAndCallback(cb, breakpoint,
@@ -509,7 +504,6 @@ module.exports.create = function(logger_, config_, fileStats_) {
       return { value: true };
     }
 
-    // TODO: we already parsed breakpoint.condition before -- pass it somehow
     var result = state.evaluate(breakpoint.condition, execState.frame(0));
 
     if (result.error) {

Original file line number	Diff line number	Diff line change
`@@ -138,8 +138,6 @@ Debuglet.prototype.scheduleRegistration_ = function(seconds) {`
`138`	`138`	`that.logger_.error('Failed to re-register debuggee: ' + err);`
`139`	`139`	`that.logger_.error('Disabling gcloud debuglet');`
`140`	`140`	`that.stop(); // fatal error`
`141`		`- // TODO: unless this is a configuration/fatal problem, maybe we should try`
`142`		`- // again after a larger delay?`
`143`	`141`	`}`
`144`	`142`
`145`	`143`	`setTimeout(function() {`