Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Commit 82bb2b8

Browse files
author
Matt Loring
committed
Store breakpoint id instead of breakpoint where possible
1 parent 4828bee commit 82bb2b8

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lib/debuglet.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ function Debuglet(config, logger) {
6868
/** @private {Object.<string, Breakpoint>} */
6969
this.activeBreakpointMap_ = {};
7070

71-
/** @private {Object.<string, Breakpoint>} */
71+
/** @private {Object.<string, Boolean>} */
7272
this.completedBreakpointMap_ = {};
7373

7474
EventEmitter.call(this);
@@ -347,9 +347,7 @@ Debuglet.prototype.completeBreakpoint_ = function(breakpoint) {
347347
if (err) {
348348
that.logger_.error('Unable to complete breakpoint on server', err);
349349
} else {
350-
// TODO(ofrobots): breakpoint may be holding on to a lot of data. We only
351-
// need to remember the breakpoint id.
352-
that.completedBreakpointMap_[breakpoint.id] = breakpoint;
350+
that.completedBreakpointMap_[breakpoint.id] = true;
353351
that.removeBreakpoint_(breakpoint);
354352
}
355353
});

0 commit comments

Comments
 (0)