Indicate breakpoint expiration using the refers_to field (#268)

matthewloring · web-flow · commit 7e2bc4fec7f2 · 2017-06-06T14:26:40.000-07:00
PR-URL: #268
diff --git a/src/agent/debuglet.js b/src/agent/debuglet.js
@@ -651,7 +651,7 @@ Debuglet.prototype.scheduleBreakpointExpiry_ = function(breakpoint) {
         format: 'The snapshot has expired'
       },
       isError: true,
-      refersTo: 'unspecified'
+      refersTo: StatusMessage.BREAKPOINT_AGE
     };
     that.completeBreakpoint_(breakpoint);
   }, (expiryTime - now) * 1000).unref();
diff --git a/src/status-message.js b/src/status-message.js
@@ -35,5 +35,6 @@ function StatusMessage(refersTo, description, isError) {
 /** @const */ StatusMessage.BREAKPOINT_EXPRESSION = 'BREAKPOINT_EXPRESSION';
 /** @const */ StatusMessage.VARIABLE_NAME = 'VARIABLE_NAME';
 /** @const */ StatusMessage.VARIABLE_VALUE = 'VARIABLE_VALUE';
+/** @const */ StatusMessage.BREAKPOINT_AGE = 'BREAKPOINT_AGE';
 
 module.exports = StatusMessage;
diff --git a/test/test-debuglet.js b/test/test-debuglet.js
@@ -660,8 +660,9 @@ describe('Debuglet', function() {
               .reply(200, {breakpoints: [bp]})
               .put(BPS_PATH + '/test',
                    function(body) {
-                     return body.breakpoint.status.description.format ===
-                            'The snapshot has expired';
+                     var status = body.breakpoint.status;
+                     return status.description.format === 'The snapshot has expired' &&
+                            status.refersTo === 'BREAKPOINT_AGE';
                    })
               .reply(200);
 
