fix: only look for relevant files in scanner test (#372)

DominicKramer · web-flow · commit 5b493170be24 · 2017-12-08T13:52:39.000-08:00
The `scanner` tests would scan all files in the `coffee` fixtures
directory to make sure the `all` and `selectFiles` methods work
correctly.  However, the initial scan would incorrectly capture
`.DS_Store` files if they were present in the `coffee` directory.
diff --git a/system-test/test-install.ts b/system-test/test-install.ts
@@ -56,7 +56,8 @@ debug.start({
     version: 'Some version'
   }
 });`,
-    description: 'imports the module and starts with a complete `serviceContext`'
+    description:
+        'imports the module and starts with a complete `serviceContext`'
   },
   {
     code: `import * as debug from '@google-cloud/debug-agent';
diff --git a/test/test-scanner.ts b/test/test-scanner.ts
@@ -25,6 +25,8 @@ const fixture = (file: string): string => {
 
 import * as scanner from '../src/agent/io/scanner';
 
+const COFFEE_FILES_REGEX = /^(.*\.js\.map)|(.*\.js)|(.*\.coffee)$/;
+
 describe('scanner', () => {
 
   describe('scan', () => {
@@ -44,19 +46,21 @@ describe('scanner', () => {
     });
 
     it('should be able to return all file stats directly', (done) => {
-      scanner.scan(true, fixture('coffee'), /.*$/).then((fileStats) => {
-        const files = Object.keys(fileStats.all());
-        assert.strictEqual(files.length, 3);
-        done();
-      });
+      scanner.scan(true, fixture('coffee'), COFFEE_FILES_REGEX)
+          .then((fileStats) => {
+            const files = Object.keys(fileStats.all());
+            assert.strictEqual(files.length, 3);
+            done();
+          });
     });
 
     it('should be able to filter to return all file stats', (done) => {
-      scanner.scan(true, fixture('coffee'), /.*$/).then((fileStats) => {
-        const files = fileStats.selectFiles(/.*$/, '');
-        assert.strictEqual(files.length, 3);
-        done();
-      });
+      scanner.scan(true, fixture('coffee'), COFFEE_FILES_REGEX)
+          .then((fileStats) => {
+            const files = fileStats.selectFiles(/.*$/, '');
+            assert.strictEqual(files.length, 3);
+            done();
+          });
     });
 
     it('should be able to filter filenames', (done) => {

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,8 @@ debug.start({`
`56`	`56`	`version: 'Some version'`
`57`	`57`	`}`
`58`	`58`	});`,
`59`		- description: 'imports the module and starts with a complete `serviceContext`'
	`59`	`+ description:`
	`60`	+ 'imports the module and starts with a complete `serviceContext`'
`60`	`61`	`},`
`61`	`62`	`{`
`62`	`63`	code: `import * as debug from '@google-cloud/debug-agent';