Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Commit 2297c09

Browse files
authored
Lint and yarn (#301)
* update yarn.lock * fix lint errors
1 parent 7ccdcd7 commit 2297c09

File tree

6 files changed

+97
-16
lines changed

6 files changed

+97
-16
lines changed

src/agent/debuglet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ export class Debuglet extends EventEmitter {
392392
// named `response`) is not used.
393393
metadata.project(
394394
'project-id',
395-
function(err: Error, _: http.ServerResponse, metadataProject: string) {
395+
function(err: Error, _res: http.ServerResponse, metadataProject: string) {
396396
// We should get an error if we are not on GCP.
397397
const onGCP = !err;
398398

src/agent/scanner.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ class ScanResultsImpl implements ScanResults {
5757
* attributes respectively
5858
* @constructor
5959
*/
60-
constructor(stats: ScanStats) {
61-
this.stats_ = stats;
60+
constructor(statsParm: ScanStats) {
61+
this.stats_ = statsParm;
6262
}
6363

6464
/**
@@ -77,7 +77,7 @@ class ScanResultsImpl implements ScanResults {
7777
* should be included in the returned results.
7878
*/
7979
selectStats(regex: RegExp): ScanStats|{} {
80-
return _.pickBy(this.stats_, function(_, key) {
80+
return _.pickBy(this.stats_, function(_ignore, key) {
8181
return regex.test(key);
8282
});
8383
}
@@ -207,7 +207,7 @@ function findFiles(
207207
return;
208208
});
209209

210-
find.on('directory', function(dir: string, _: fs.Stats, stop: () => void) {
210+
find.on('directory', function(dir: string, _ignore: fs.Stats, stop: () => void) {
211211
const base = path.basename(dir);
212212
if (base === '.git' || base === 'node_modules') {
213213
stop(); // do not descend

src/agent/sourcemapper.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ export function create(
3939
callback: (err: Error|null, mapper?: SourceMapper) => void): void {
4040
const mapper = new SourceMapper();
4141
const callList =
42-
Array.prototype.slice.call(sourcemapPaths).map(function(path: string) {
42+
Array.prototype.slice.call(sourcemapPaths).map(function(p: string) {
4343
return function(cb: (err: Error|null) => void) {
44-
processSourcemap(mapper.infoMap_, path, cb);
44+
processSourcemap(mapper.infoMap_, p, cb);
4545
};
4646
});
4747

src/agent/state.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class StateResolver {
154154
// Evaluate the watch expressions
155155
const evalIndexSet = new Set();
156156
if (that.expressions_) {
157-
that.expressions_.forEach(function(expression, index) {
157+
that.expressions_.forEach(function(expression, index2) {
158158
const result = evaluate(expression, that.state_.frame(0));
159159
let evaluated;
160160

@@ -174,7 +174,7 @@ class StateResolver {
174174
evalIndexSet.add(varTableIdx);
175175
}
176176
}
177-
that.evaluatedExpressions_[index] = evaluated;
177+
that.evaluatedExpressions_[index2] = evaluated;
178178
});
179179
}
180180

src/agent/v8debugapi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ export function create(
254254
let timesliceEnd = Date.now() + 1000;
255255
// TODO: Determine why the Error argument is not used.
256256
const listener =
257-
onBreakpointHit.bind(null, breakpoint, function(_: Error) {
257+
onBreakpointHit.bind(null, breakpoint, function(_err: Error) {
258258
const currTime = Date.now();
259259
if (currTime > timesliceEnd) {
260260
logsThisSecond = 0;

yarn.lock

Lines changed: 87 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,40 @@
4242
normalize-path "^2.0.1"
4343
through2 "^2.0.3"
4444

45+
"@types/acorn@^4.0.2":
46+
version "4.0.2"
47+
resolved "https://registry.yarnpkg.com/@types/acorn/-/acorn-4.0.2.tgz#5c37dade857a53c14258c914d43e634076aec3fd"
48+
dependencies:
49+
"@types/estree" "*"
50+
51+
"@types/async@^2.0.40":
52+
version "2.0.40"
53+
resolved "https://registry.yarnpkg.com/@types/async/-/async-2.0.40.tgz#ac02de68e66c004a61b7cb16df8b1db3a254cca9"
54+
55+
"@types/estree@*", "@types/[email protected]":
56+
version "0.0.35"
57+
resolved "https://registry.yarnpkg.com/@types/estree/-/estree-0.0.35.tgz#8999974b34028686a8d61a719e61c138d3755107"
58+
59+
"@types/extend@^2.0.30":
60+
version "2.0.30"
61+
resolved "https://registry.yarnpkg.com/@types/extend/-/extend-2.0.30.tgz#58cc93f621d0a358d3fec9bd6e739bc60ec7e275"
62+
63+
"@types/lodash@^4.14.66":
64+
version "4.14.68"
65+
resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.68.tgz#754fbab68bd2bbb69547dc8ce7574f7012eed7f6"
66+
4567
"@types/node@^7.0.18":
4668
version "7.0.18"
4769
resolved "https://registry.yarnpkg.com/@types/node/-/node-7.0.18.tgz#cd67f27d3dc0cfb746f0bdd5e086c4c5d55be173"
4870

71+
"@types/semver@^5.3.31":
72+
version "5.3.32"
73+
resolved "https://registry.yarnpkg.com/@types/semver/-/semver-5.3.32.tgz#a7afdc4bee713c081114cd811b51be10907d7bae"
74+
75+
"@types/source-map@^0.5.0":
76+
version "0.5.0"
77+
resolved "https://registry.yarnpkg.com/@types/source-map/-/source-map-0.5.0.tgz#dd34bbd8e32fe4e74f2e3d8ac07f8aa5b45a47ac"
78+
4979
5080
version "1.0.9"
5181
resolved "https://registry.yarnpkg.com/abbrev/-/abbrev-1.0.9.tgz#91b4792588a7738c25f35dd6f63752a2f8776135"
@@ -186,6 +216,14 @@ aws4@^1.2.1:
186216
version "1.6.0"
187217
resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.6.0.tgz#83ef5ca860b2b32e4a0deedee8c771b9db57471e"
188218

219+
babel-code-frame@^6.22.0:
220+
version "6.22.0"
221+
resolved "https://registry.yarnpkg.com/babel-code-frame/-/babel-code-frame-6.22.0.tgz#027620bee567a88c32561574e7fd0801d33118e4"
222+
dependencies:
223+
chalk "^1.1.0"
224+
esutils "^2.0.2"
225+
js-tokens "^3.0.0"
226+
189227
balanced-match@^1.0.0:
190228
version "1.0.0"
191229
resolved "https://registry.yarnpkg.com/balanced-match/-/balanced-match-1.0.0.tgz#89b4d199ab2bee49de164ea02b89ce462d71b767"
@@ -282,7 +320,7 @@ center-align@^0.1.1:
282320
deep-eql "^0.1.3"
283321
type-detect "^1.0.0"
284322

285-
chalk@^1.0.0, chalk@^1.1.1, chalk@~1.1.3:
323+
chalk@^1.0.0, chalk@^1.1.0, chalk@^1.1.1, chalk@~1.1.3:
286324
version "1.1.3"
287325
resolved "https://registry.yarnpkg.com/chalk/-/chalk-1.1.3.tgz#a8115c55e4a702fe4d150abd3872822a7e09fc98"
288326
dependencies:
@@ -309,7 +347,7 @@ changelog-maker@^2.2.2:
309347
pkg-to-id "~0.0.3"
310348
split2 "~2.1.1"
311349

312-
clang-format@^1.0.32:
350+
clang-format@^1.0.32, clang-format@^1.0.53:
313351
version "1.0.53"
314352
resolved "https://registry.yarnpkg.com/clang-format/-/clang-format-1.0.53.tgz#ff3668c40ecceeeeaa3e977b61d50106d0b3fd46"
315353
dependencies:
@@ -367,6 +405,10 @@ coffee-script@^1.9.3:
367405
version "1.12.6"
368406
resolved "https://registry.yarnpkg.com/coffee-script/-/coffee-script-1.12.6.tgz#285a3f7115689065064d6bf9ef4572db66695cbf"
369407

408+
colors@^1.1.2:
409+
version "1.1.2"
410+
resolved "https://registry.yarnpkg.com/colors/-/colors-1.1.2.tgz#168a4701756b6a7f51a12ce0c97bfa28c084ed63"
411+
370412
combined-stream@^1.0.5, combined-stream@~1.0.5:
371413
version "1.0.5"
372414
resolved "https://registry.yarnpkg.com/combined-stream/-/combined-stream-1.0.5.tgz#938370a57b4a51dea2c77c15d5c5fdf895164009"
@@ -536,7 +578,7 @@ [email protected]:
536578
version "2.1.0"
537579
resolved "https://registry.yarnpkg.com/detect-newline/-/detect-newline-2.1.0.tgz#f41f1c10be4b00e87b5f13da680759f2c5bfd3e2"
538580

539-
581+
[email protected], diff@^3.2.0:
540582
version "3.2.0"
541583
resolved "https://registry.yarnpkg.com/diff/-/diff-3.2.0.tgz#c9ce393a4b7cbd0b058a725c93df299027868ff9"
542584

@@ -1162,7 +1204,7 @@ gulp-sourcemaps@^2.6.0:
11621204
through2 "2.X"
11631205
vinyl "1.X"
11641206

1165-
gulp-tslint@^8.0.0:
1207+
gulp-tslint@^8.1.1:
11661208
version "8.1.1"
11671209
resolved "https://registry.yarnpkg.com/gulp-tslint/-/gulp-tslint-8.1.1.tgz#1a906e59facaeacda900f3b412b0f46cfb0ab89f"
11681210
dependencies:
@@ -1529,6 +1571,10 @@ istanbul@^0.4.1:
15291571
which "^1.1.1"
15301572
wordwrap "^1.0.0"
15311573

1574+
js-tokens@^3.0.0:
1575+
version "3.0.2"
1576+
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-3.0.2.tgz#9866df395102130e38f7f996bceb65443209c25b"
1577+
15321578
15331579
version "3.6.1"
15341580
resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.6.1.tgz#6e5fe67d8b205ce4d22fad05b7781e8dadcc4b30"
@@ -1907,7 +1953,7 @@ mime@^1.2.11:
19071953
version "1.3.6"
19081954
resolved "https://registry.yarnpkg.com/mime/-/mime-1.3.6.tgz#591d84d3653a6b0b4a3b9df8de5aa8108e72e5e0"
19091955

1910-
"minimatch@2 || 3", minimatch@^3.0.2, minimatch@~3.0.2:
1956+
"minimatch@2 || 3", minimatch@^3.0.2, minimatch@^3.0.4, minimatch@~3.0.2:
19111957
version "3.0.4"
19121958
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-3.0.4.tgz#5166e286457f03306064be5497e8dbb0c3d32083"
19131959
dependencies:
@@ -2132,6 +2178,10 @@ path-is-inside@^1.0.1:
21322178
version "1.0.2"
21332179
resolved "https://registry.yarnpkg.com/path-is-inside/-/path-is-inside-1.0.2.tgz#365417dede44430d1c11af61027facf074bdfc53"
21342180

2181+
path-parse@^1.0.5:
2182+
version "1.0.5"
2183+
resolved "https://registry.yarnpkg.com/path-parse/-/path-parse-1.0.5.tgz#3c1adf871ea9cd6c9431b6ea2bd74a0ff055c4c1"
2184+
21352185
path-root-regex@^0.1.0:
21362186
version "0.1.2"
21372187
resolved "https://registry.yarnpkg.com/path-root-regex/-/path-root-regex-0.1.2.tgz#bfccdc8df5b12dc52c8b43ec38d18d72c04ba96d"
@@ -2389,6 +2439,12 @@ [email protected], resolve@^1.1.6, resolve@^1.1.7, resolve@~1.1.7:
23892439
version "1.1.7"
23902440
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.1.7.tgz#203114d82ad2c5ed9e8e0411b3932875e889e97b"
23912441

2442+
resolve@^1.3.2:
2443+
version "1.3.3"
2444+
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.3.3.tgz#655907c3469a8680dc2de3a275a8fdd69691f0e5"
2445+
dependencies:
2446+
path-parse "^1.0.5"
2447+
23922448
retry-request@^1.3.2:
23932449
version "1.3.2"
23942450
resolved "https://registry.yarnpkg.com/retry-request/-/retry-request-1.3.2.tgz#59ad24e71f8ae3f312d5f7b4bcf467a5e5a57bd6"
@@ -2427,7 +2483,7 @@ semver@^4.1.0:
24272483
version "4.3.6"
24282484
resolved "https://registry.yarnpkg.com/semver/-/semver-4.3.6.tgz#300bc6e0e86374f7ba61068b5b1ecd57fc6532da"
24292485

2430-
semver@^5.1.0:
2486+
semver@^5.1.0, semver@^5.3.0:
24312487
version "5.3.0"
24322488
resolved "https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f"
24332489

@@ -2694,6 +2750,31 @@ tough-cookie@~2.3.0:
26942750
dependencies:
26952751
punycode "^1.4.1"
26962752

2753+
tslib@^1.7.1:
2754+
version "1.7.1"
2755+
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.7.1.tgz#bc8004164691923a79fe8378bbeb3da2017538ec"
2756+
2757+
tslint@^5.4.3:
2758+
version "5.5.0"
2759+
resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.5.0.tgz#10e8dab3e3061fa61e9442e8cee3982acf20a6aa"
2760+
dependencies:
2761+
babel-code-frame "^6.22.0"
2762+
colors "^1.1.2"
2763+
commander "^2.9.0"
2764+
diff "^3.2.0"
2765+
glob "^7.1.1"
2766+
minimatch "^3.0.4"
2767+
resolve "^1.3.2"
2768+
semver "^5.3.0"
2769+
tslib "^1.7.1"
2770+
tsutils "^2.5.1"
2771+
2772+
tsutils@^2.5.1:
2773+
version "2.5.1"
2774+
resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-2.5.1.tgz#c2001390c79eec1a5ccfa7ac12d599639683e0cf"
2775+
dependencies:
2776+
tslib "^1.7.1"
2777+
26972778
tunnel-agent@^0.6.0:
26982779
version "0.6.0"
26992780
resolved "https://registry.yarnpkg.com/tunnel-agent/-/tunnel-agent-0.6.0.tgz#27a5dea06b36b04a0a9966774b290868f0fc40fd"

0 commit comments

Comments
 (0)